Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: Add profiling script #1566

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

rsc: Add profiling script #1566

wants to merge 1 commit into from

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented May 14, 2024

I threw together a basic script for profiling the rsc. Nothing too fancy but useful for evaluating potential performance changes.

@V-FEXrt V-FEXrt requested review from colinschmidt and ag-eitilt May 14, 2024 20:25
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a PR you're hoping to get a review on, or did you just push it for future reference? I can't quite tell from the description.

Comment on lines +34 to +36
"cmd": [47,117,115,114],
"cwd":".",
"env":[80,65,84,72,61,47],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these seemingly-magic numbers documented anywhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These numbers themselves are made up. Its just the byte representation of the command/environment string of the job. The fact that you need to serialize those values into a byte array is documented in the api type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants