-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rsc: Enable RSC to build with rust 1.8 #1621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this doesn't update rust/log_viewer/Cargo.lock
, is that deliberate? It's falling a bit behind on version pinning (e.g. it asks for mio
v0.8.8, where this bumps that to both v0.8.11 or v1.0.1, depending on where the dependency occurs) but I don't know if it would actually cause the same issues we're running into with CI.
nope, just forgot about it Though looks like rocky8 requires an older version of rust? this might be a pain |
Yeah, that will definitely make things interesting. And the only reason I noticed the missing file was because I went through the list of dependabot warnings to see what this would clear up (answer: a fair number of the Rust ones, but since the majority of issues are with JavaScript we'll still definitely have a good few left). |
I swear one day I'm going to remake the VSCode extension now that I know the proper way to do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Disabling Alpine for now makes sense, but we should take another look on whether that should be a permanent change after the next release.
One of the RSC's dependencies doesn't build against rust 1.8 which GHActions is now using by default. This PR updates the deps so that CI can pass again