Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsc: Enable RSC to build with rust 1.8 #1621

Merged
merged 4 commits into from
Aug 5, 2024
Merged

rsc: Enable RSC to build with rust 1.8 #1621

merged 4 commits into from
Aug 5, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Aug 2, 2024

One of the RSC's dependencies doesn't build against rust 1.8 which GHActions is now using by default. This PR updates the deps so that CI can pass again

Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this doesn't update rust/log_viewer/Cargo.lock, is that deliberate? It's falling a bit behind on version pinning (e.g. it asks for mio v0.8.8, where this bumps that to both v0.8.11 or v1.0.1, depending on where the dependency occurs) but I don't know if it would actually cause the same issues we're running into with CI.

@V-FEXrt
Copy link
Contributor Author

V-FEXrt commented Aug 2, 2024

is that deliberate

nope, just forgot about it

Though looks like rocky8 requires an older version of rust? this might be a pain

@ag-eitilt
Copy link
Collaborator

Yeah, that will definitely make things interesting. And the only reason I noticed the missing file was because I went through the list of dependabot warnings to see what this would clear up (answer: a fair number of the Rust ones, but since the majority of issues are with JavaScript we'll still definitely have a good few left).

@V-FEXrt
Copy link
Contributor Author

V-FEXrt commented Aug 2, 2024

but since the majority of issues are with JavaScript

I swear one day I'm going to remake the VSCode extension now that I know the proper way to do it

Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Disabling Alpine for now makes sense, but we should take another look on whether that should be a permanent change after the next release.

@V-FEXrt V-FEXrt merged commit d46a0c6 into master Aug 5, 2024
10 checks passed
@V-FEXrt V-FEXrt deleted the rsc-fix-build branch August 5, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants