Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode: Restore Extension #1632

Merged
merged 6 commits into from
Aug 20, 2024
Merged

vscode: Restore Extension #1632

merged 6 commits into from
Aug 20, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Aug 16, 2024

Reworks the VSCode extension to be much simplier and compatible with modern versions of its dependencies

@V-FEXrt V-FEXrt marked this pull request as ready for review August 16, 2024 23:38
colinschmidt
colinschmidt reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a reasonable rewrite to align with the standard language client model in VSCode.

.github/workflows/build.yaml Show resolved Hide resolved
build.wake Show resolved Hide resolved
extensions/vscode/.vscodeignore Show resolved Hide resolved
extensions/vscode/package.json.in Outdated Show resolved Hide resolved
extensions/vscode/package.json.in Outdated Show resolved Hide resolved
extensions/vscode/src/extension.ts Outdated Show resolved Hide resolved
extensions/vscode/src/test/extension.test.ts Outdated Show resolved Hide resolved
extensions/vscode/tsconfig.json Outdated Show resolved Hide resolved
extensions/vscode/vscode.wake Show resolved Hide resolved
extensions/vscode/esbuild.js Outdated Show resolved Hide resolved
colinschmidt
colinschmidt approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@V-FEXrt V-FEXrt merged commit 835d80a into master Aug 20, 2024
11 checks passed
@V-FEXrt V-FEXrt deleted the vscode-ci branch August 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinschmidt colinschmidt colinschmidt approved these changes

@ag-eitilt ag-eitilt Awaiting requested review from ag-eitilt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@V-FEXrt @colinschmidt