rsc: Hidden directories should be returned as cleanable outputs #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinschmidt
approved these changes
Sep 30, 2024
| @@ -237,7 +244,7 @@ export def mkRemoteCacheRunner (rscApi: RemoteCacheApi) (hashFn: RunnerInput => | |||
| # by the same job. If so, upload the target as a "hidden" output file. On rehydration | |||
| # retore the file as normal but don't list it in the outputs. | |||
| ## -------------------------------------------------------------------------------------- ## | |||
| Pass (RunnerOutput inputs outputs Nil predict) | |||
| Pass (RunnerOutput inputs outputs cleanableOutputs predict) | |||
There was a problem hiding this comment.
Ah this Nil should have triggered something in our brains during code review I guess.
There was a problem hiding this comment.
Yeah, I had the same thought. It was subtle but it should have been a flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rehydrating from the cache, any "hidden" directories should be listed as cleanable outputs since they aren't listed as actual outputs by the runner. If they aren't listed then they won't get cleaned up as expected by
wake --clean