Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Switch to available formatter #1666

Merged
merged 2 commits into from
Oct 18, 2024
Merged

ci: Switch to available formatter #1666

merged 2 commits into from
Oct 18, 2024

Conversation

V-FEXrt
Copy link
Contributor

@V-FEXrt V-FEXrt commented Oct 18, 2024

clang-format-12 is no longer available in CI now that ubuntu-latest points to 24.04. Switch to a newer one

ag-eitilt
ag-eitilt approved these changes Oct 18, 2024
View reviewed changes
Copy link
Collaborator

@ag-eitilt ag-eitilt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't say I think the formatting is an improvement, but it's nothing I'll have to interact with too often, and updating to the current version is definitely good.

@V-FEXrt V-FEXrt requested a review from colinschmidt October 18, 2024 19:47
colinschmidt
colinschmidt approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@colinschmidt colinschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@V-FEXrt V-FEXrt merged commit 0220c86 into master Oct 18, 2024
11 checks passed
@V-FEXrt V-FEXrt deleted the fix-ci-format branch October 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ag-eitilt ag-eitilt ag-eitilt approved these changes

@colinschmidt colinschmidt colinschmidt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@V-FEXrt @colinschmidt @ag-eitilt