-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OAUTH_CUSTOM_FULL mode #527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this already be supported via
https://github.com/sigma67/ytmusicapi/blob/main/ytmusicapi/ytmusic.py#L190-L191
If not, can we have a test as well that covers the difference and ensures it won't break again in the future?
Good point! In that case I would need to make some changes to this line, as the token is None for full custom oauth: ytmusicapi/ytmusicapi/ytmusic.py Line 215 in 9170197
|
Yeah, is it enough to just not set |
Absolutely, fixed that |
@MarvinSchenkel please submit to |
Sorry I wasn't aware. My existing fork was still pointing to master. |
I deleted the (don't worry I'll push your commit shortly) |
* Fix OAUTH_CUSTOM_FULL mode * Fix OAUTH_CUSTOM_FULL mode
This PR adds the missing
AuthType.OAUTH_CUSTOM_FULL
mode when calculating the headers. We (Music Assistant) use our own web-based OAuth process to retrieve an acces token. In this scenario we also provide the other required headers to interact with Youtube Music.