This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Handle the case of a missing group session signature key #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we get into a state where the group session lacks a signature key, make sure the encrypt fails with an InvalidKeyException. This allows the code calling encrypt() to handle the condition by clearing the session. We can get into this state if we try to encrypt a message from a session that was previously used for decrypting messages.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the library gets into a state where the group session lacks a signature key,
make sure that encrypt fails with an InvalidKeyException. This allows the
code calling encrypt() to handle the condition by clearing the session.
The library can most easily get into this state if you try to encrypt a message from a session
that was previously used for decrypting messages.