-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mustache escaping #262
Conversation
setup.py
Outdated
@@ -25,6 +25,7 @@ | |||
|
|||
with open(os.path.join(here, 'requirements.txt')) as requirements_fp: | |||
install_requires = requirements_fp.read().split('\n') | |||
install_requires.append("chevron @ git+https://github.com/taylorjacklespriggs/chevron@support-custom-escaping") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last commit was mar 21, 2021. not confident this will get merged any time soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a cannonical address (since we can update the branch and it will install the newer updates). Not sure if that's better or not, but wanted to mention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer we maybe fork into sigopt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me, almost identical for licensing. As a bonus, chevron has no requirements so we wouldn't even need to update requirements.txt
setup.py
Outdated
@@ -25,6 +25,7 @@ | |||
|
|||
with open(os.path.join(here, 'requirements.txt')) as requirements_fp: | |||
install_requires = requirements_fp.read().split('\n') | |||
install_requires.append("chevron @ git+https://github.com/taylorjacklespriggs/chevron@support-custom-escaping") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a cannonical address (since we can update the branch and it will install the newer updates). Not sure if that's better or not, but wanted to mention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going away due to PR #266 and friends?
that is right |
replaced by #266 |
No description provided.