decoders/sdcard_spi: CMD17/CMD24 bugfix, added support for CMD12,CMD18 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blastsnes
commented
Jun 13, 2022
blastsnes
commented
- BUGFIX: CMD17/CMD24 only worked once. Any following CMD17/CMD24 were missed because self.is_cmd17/self.is_cmd24 were not reset after a successful command.
- TODO implemented: CRC-16 validation in CMD17
- added support for CMD18 (READ_MULTIPLE_BLOCK)
- added support for CMD12 (STOP_TRANSMISSION) which CMD18 depends on
- BUGFIX: CMD17/CMD24 only worked once. Any following CMD17/CMD24 were missed because self.is_cmd17/self.is_cmd24 were not reset after a successful command. - TODO implemented: CRC-16 validation in CMD17 - added support for CMD18 (READ_MULTIPLE_BLOCK) - added support for CMD12 (STOP_TRANSMISSION) which CMD18 depends on
snmoore
added a commit
to Inflowmatix/libsigrokdecode
that referenced
this pull request
Nov 11, 2022
Reset the CMD17 state once the block data has been handled. Fix by blastsnes, taken from PR sigrokproject#87 from https://github.com/blastsnes/libsigrokdecode_sd_card_spi/tree/sd_card_spi_fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.