Test and fix verbatim line handling #2129
Conversation
|
Would this meet the expectations? (your test here + an additional check + the autodoc blurb from the manual cited in the issue):
If so, I can try to make it neat, perhaps this week-end. (Using a hack currently, but the path from that point seems to be the way to go, if it doesn't break anything else...) |
|
Yes that output looks right. The final test should have as little noise as possible but testing the double line scenario makes sense. Feel Free to push WIP to this branch or PR to target it. My dev time is total chaos right now. Our son was born last week but had complications and is in the NICU for a while. I'm fiddling with FOSS here and there in waiting rooms to keep time moving. |
I'm sincerely sorry to hear about the complications. I can't imagine how hard this must be for you and your wife. I’m keeping you all, and your baby in my thoughts and hoping for a smooth recovery.
Just pushed a few commits on top of yours (the extra 2-line test, fixes to the verbatim/autodoc packages, and the crux of the issue in the typesetter). One test fails (bug-132) -- and it's actually a verbatim-related test, so that seems expected (I just looked at it very quicky, it does seem ok and it's likely caused by the parskip/baselineskip adjusments). This remains an empirical WIP, though, I'll go on checking the changes and possibly backport them to my own environments to see how they behave here (the user guides for resilient.sile and markdown.sile have plenty of verbatim-like blocks too, so I'm eager to check how these changes would behave in that context...). But for now (3 AM lol), I need some sleep :p |
Thank you. We and our son have had a rough go of it. His heart stopped during birth and he ended up with stage 2 hypoxic-ischemic encephalopathy, spent 10 days in ICU, and is still under close neurological monitoring. Physically he's recovering fairly well although brain activity on an EEG is still abnormal. But we're glad he's home with us now and we're praying for his eventual full recovery. |
alerque
force-pushed
the
verbatim-lines
branch
from
e9fd3b0
to
4e93f65
Compare
Honor the fixed part of left/right (margin) skips, so that verbatim works in indented environments (e.g. a block quote) Kill paragraph skips (very likely not expected in verbatim) and restore proper baseline skips instead of ad-hoc spaces. This also applies to autodoc's code blocks, simplified and aligned on the same principles.
alerque
force-pushed
the
verbatim-lines
branch
from
4e93f65
to
73cd72c
Compare
Closes #2128
...as of posting all I have is a test that shows its broken.