Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support MathML mroot #2141

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Support MathML mroot #2141

merged 2 commits into from
Oct 29, 2024

Conversation

Omikhleia
Copy link
Member

@Omikhleia Omikhleia commented Oct 19, 2024 •
edited
Loading

Ticks a box in #2120

image

Also slightly improved the look of the "fake" radical sign (both mroot and msqrt use the same common implementation node)

@Omikhleia Omikhleia requested review from a team and alerque as code owners October 19, 2024 10:29
@Omikhleia Omikhleia added the enhancement Software improvement or feature request label Oct 19, 2024
@Omikhleia Omikhleia added this to the v0.15.6 milestone Oct 19, 2024
@Omikhleia Omikhleia self-assigned this Oct 19, 2024
@Omikhleia Omikhleia marked this pull request as draft October 19, 2024 10:30
@Omikhleia Omikhleia marked this pull request as ready for review October 19, 2024 12:40
@Omikhleia Omikhleia mentioned this pull request Oct 19, 2024
Open
2 tasks
@Omikhleia
Copy link
Member Author

N.B. I can consider TeX math-like \sqrt[n]{base} separately, after this and #2140 are merged, as it touches the same parts of the code.

@Omikhleia Omikhleia mentioned this pull request Oct 19, 2024
Open
alerque
alerque previously approved these changes Oct 29, 2024
View reviewed changes
@alerque alerque merged commit b5127d6 into sile-typesetter:master Oct 29, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alerque alerque alerque approved these changes

Assignees

@Omikhleia Omikhleia

Labels
enhancement Software improvement or feature request
Projects
Math
Status: Done
Milestone
v0.15.6
Development

Successfully merging this pull request may close these issues.
2 participants
@Omikhleia @alerque