Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntries] Refactor sort-by handling #2732

Merged
merged 7 commits into from
Oct 30, 2023
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 23, 2023

Fixes #2733

This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Files Coverage Δ
...EntriesComponent/CellComponents/DefinitionCell.tsx 66.66% <ø> (ø)
...eviewEntriesComponent/CellComponents/GlossCell.tsx 66.66% <ø> (ø)
...viewEntriesComponent/CellComponents/DomainCell.tsx 30.30% <75.00%> (+4.49%) ⬆️
...viewEntriesComponent/Redux/ReviewEntriesActions.ts 62.85% <50.00%> (-0.38%) ⬇️
...viewEntriesComponent/Redux/ReviewEntriesReducer.ts 55.55% <50.00%> (-6.95%) ⬇️
...als/ReviewEntries/ReviewEntriesComponent/index.tsx 66.66% <0.00%> (-8.34%) ⬇️
...ries/ReviewEntriesComponent/ReviewEntriesTable.tsx 66.66% <50.00%> (-3.34%) ⬇️
...viewEntries/ReviewEntriesComponent/CellColumns.tsx 62.50% <42.85%> (+1.66%) ⬆️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) October 30, 2023 16:23
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 891a84c into master Oct 30, 2023
16 checks passed
@imnasnainaec imnasnainaec deleted the review-entries-sort branch October 30, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReviewEntries] Semantic domain column sort formatting doesn't clear
3 participants