Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReviewEntriesTable] Add fuzzy/exact filtering #3436

Merged
merged 7 commits into from
Nov 6, 2024
Merged

[ReviewEntriesTable] Add fuzzy/exact filtering #3436

merged 7 commits into from
Nov 6, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Nov 5, 2024

Resolves #3407


This change is Reviewable

@imnasnainaec imnasnainaec changed the title Add fuzzy/exact filtering [ReviewEntriesTable] Add fuzzy/exact filtering Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.62%. Comparing base (a4aa54c) to head (1a2eb29).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   74.56%   74.62%   +0.06%     
==========================================
  Files         285      285              
  Lines       10987    10999      +12     
  Branches     1337     1339       +2     
==========================================
+ Hits         8192     8208      +16     
+ Misses       2410     2407       -3     
+ Partials      385      384       -1     
Flag Coverage Δ
backend 83.62% <ø> (+0.07%) ⬆️
frontend 66.62% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review November 6, 2024 14:14
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 6 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit d70d5a5 into master Nov 6, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the filter branch November 6, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ReviewEntries] Allow both fuzzy and non-fuzzy column filtering
2 participants