-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public StartClone() method #325
Merged
Merged
Changes from 6 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f49d876
Added public StartClone() option
josephmyers ad42833
Split project name from URI to its own param
josephmyers 0f884e8
Using full URI to pass to Mercurial
josephmyers 0baa937
Made the method static
josephmyers 31df94d
Updated changelog
josephmyers 6d98401
Moved all caller operations into the method
josephmyers 45ba1ef
Centralise CloneResult generation and simplify DoClone
papeh 57ce434
Simplify GetSharedProjectModel.GetResult
papeh 448125f
Add public GCFInternetDlg.ConfirmAndDoClone
papeh dd31a7e
Pass URI as a string to match other ServerSettingsModel
papeh 2f15202
Revert user/pass after clone
josephmyers 6e7c775
Revert in finally block and behind optional flag
josephmyers 473c798
Added flag for the other method, as well
josephmyers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"without user interaction": there's no indirect interaction, either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my mind, the indirect user interaction is them using the wrapping software. They still have to do something to get the clone to happen.