Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public StartClone() method #325

Merged
merged 13 commits into from
Oct 13, 2023
Merged

Add public StartClone() method #325

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f49d876
Added public StartClone() option
josephmyers Sep 28, 2023
ad42833
Split project name from URI to its own param
josephmyers Sep 29, 2023
0f884e8
Using full URI to pass to Mercurial
josephmyers Sep 29, 2023
0baa937
Made the method static
josephmyers Oct 5, 2023
31df94d
Updated changelog
josephmyers Oct 5, 2023
6d98401
Moved all caller operations into the method
josephmyers Oct 6, 2023
45ba1ef
Centralise CloneResult generation and simplify DoClone
papeh Oct 6, 2023
57ce434
Simplify GetSharedProjectModel.GetResult
papeh Oct 6, 2023
448125f
Add public GCFInternetDlg.ConfirmAndDoClone
papeh Oct 9, 2023
dd31a7e
Pass URI as a string to match other ServerSettingsModel
papeh Oct 9, 2023
2f15202
Revert user/pass after clone
josephmyers Oct 12, 2023
6e7c775
Revert in finally block and behind optional flag
josephmyers Oct 13, 2023
473c798
Added flag for the other method, as well
josephmyers Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/Chorus/UI/Clone/GetCloneFromInternetDialog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,11 +261,27 @@ private void _cancelButton_Click(object sender, EventArgs e)
}

private void OnDownloadClick(object sender, EventArgs e)
{
StartClone();
}

public void StartClone(string username, string password, Uri targetUri)
{
_model.Username = username;
_model.Password = password;
_model.CustomUrl = targetUri.ToString();
_model.IsCustomUrl = true;
_model.LocalFolderName = GetProjectName(targetUri);
hahn-kev marked this conversation as resolved.
Show resolved Hide resolved

StartClone();
}

private void StartClone()
{
lock (this)
{
_logBox.Clear();
if(_backgroundWorker.IsBusy)
if (_backgroundWorker.IsBusy)
return;
UpdateDisplay(State.MakingClone);
_model.SaveUserSettings();
Expand All @@ -275,6 +291,10 @@ private void OnDownloadClick(object sender, EventArgs e)
}
}

private string GetProjectName(Uri uri)
{
return uri.Segments[1].ToString();
}

public string ThreadSafeUrl
{
Expand Down
Loading