Remove LcmCrdt specific MiniLcm models #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C# Unit Tests75 tests 75 ✅ 5s ⏱️ Results for commit 2d25c9c. ♻️ This comment has been updated with latest results. |
# Conflicts: # backend/FwLite/FwLiteProjectSync.Tests/SyncTests.cs # backend/FwLite/FwLiteProjectSync.Tests/UpdateDiffTests.cs # backend/FwLite/LcmCrdt/CrdtMiniLcmApi.cs # backend/FwLite/LcmCrdt/LcmCrdtKernel.cs # backend/FwLite/LcmCrdt/Objects/Entry.cs # backend/FwLite/MiniLcm/Models/Entry.cs # backend/LfClassicData/LfClassicMiniLcmApi.cs
hahn-kev
requested review from
rmunn and
myieye
and removed request for
rmunn
myieye
previously approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR incorporates Harmony changes made in sillsdev/harmony#15 which allows us to define an adapter for all our objects so they don't need to reference Harmony. This greatly simplifies how EF queries our data because we don't have to contend with inheritance