Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort kbts #277

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Sort kbts #277

merged 2 commits into from
Nov 27, 2024

Conversation

Enkidu93
Copy link
Collaborator

@Enkidu93 Enkidu93 commented Nov 27, 2024

Maybe there's a better to do this since, at least, the terms pulled from the localizations should already be sorted? Or maybe OrderBy handles that well?


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.14%. Comparing base (c16788d) to head (78d1e99).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #277   +/-   ##
=======================================
  Coverage   70.14%   70.14%           
=======================================
  Files         385      385           
  Lines       31960    31962    +2     
  Branches     4489     4489           
=======================================
+ Hits        22418    22420    +2     
  Misses       8499     8499           
  Partials     1043     1043           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

Why do unsorted keyterms cause an issue?

@Enkidu93
Copy link
Collaborator Author

Why do unsorted keyterms cause an issue?

They cannot be aligned properly

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should perform the sort in the corpus classes. Other consumers of the parser classes might not care about the order.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@Enkidu93
Copy link
Collaborator Author

You should perform the sort in the corpus classes. Other consumers of the parser classes might not care about the order.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

Done.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

@Enkidu93 Enkidu93 merged commit 96ee214 into master Nov 27, 2024
4 checks passed
@Enkidu93 Enkidu93 deleted the sort_kbt branch November 27, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants