Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubbed in a temporary minimal implementation of check for updates #189

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tombogle
Copy link
Collaborator

@tombogle tombogle commented Jul 15, 2024

This change is Reviewable

@tombogle tombogle requested a review from andrew-polk July 15, 2024 21:30
@tombogle tombogle self-assigned this Jul 15, 2024
Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)


src/SayMore/UI/ProjectWindow/ProjectWindow.cs line 261 at r1 (raw file):

		{
			Analytics.Track("CheckForUpdates");
			MessageBox.Show("Note yet implemented. Visit software.sil.org/saymore/download to check for updated version.", ProductName);

typo: Note

But I think I would skip the first sentence. It is fairly technical language.

"Please visit software.sil.org/saymore/download to check for updated version."

You could even make it a yes/no which, if they click Yes, takes them to the site. (Who is going to type in the address?...)

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tombogle)


src/SayMore/UI/ProjectWindow/ProjectWindow.cs line 261 at r1 (raw file):

Previously, andrew-polk wrote…

typo: Note

But I think I would skip the first sentence. It is fairly technical language.

"Please visit software.sil.org/saymore/download to check for updated version."

You could even make it a yes/no which, if they click Yes, takes them to the site. (Who is going to type in the address?...)

"Please visit software.sil.org/saymore/download to check for an updated version."
(added "an")

@tombogle
Copy link
Collaborator Author

Good thoughts. Not sure I'll even release this, but I wanted to at least stub something in as a reminder to think about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants