Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies with vulnerabilities #549

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

ddaspit
Copy link
Contributor

@ddaspit ddaspit commented Nov 28, 2024


This change is Reviewable

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 27 lines in your changes missing coverage. Please review.

Project coverage is 57.08%. Comparing base (03e4716) to head (05489aa).

Files with missing lines Patch % Lines
...IL.ServiceToolkit/Services/BugsnagStartupFilter.cs 54.54% 14 Missing and 1 partial ⚠️
...c/SIL.ServiceToolkit/Services/BugsnagMiddleware.cs 69.44% 8 Missing and 3 partials ⚠️
...hine/src/Serval.Machine.Shared/Utils/AsyncTimer.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   57.03%   57.08%   +0.04%     
==========================================
  Files         302      304       +2     
  Lines       15639    15720      +81     
  Branches     2155     2163       +8     
==========================================
+ Hits         8919     8973      +54     
- Misses       6076     6099      +23     
- Partials      644      648       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnml1135
Copy link
Collaborator

src/ServiceToolkit/src/SIL.ServiceToolkit/Services/BugsnagMiddleware.cs line 6 at r1 (raw file):

/// The Bugsnag AspNetCore middleware.
/// </summary>
public class BugsnagMiddleware(RequestDelegate requestDelegate)

Is this just a copy-paste from the Bugsnag implementation? If it is, can you reference the source of it in a comment? In 3 years, Bugsnag may update some of it and it would be nice to know what is the same and different, and when it was forked.

Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 15 files at r1, all commit messages.
Reviewable status: 13 of 15 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)

Copy link
Collaborator

@Enkidu93 Enkidu93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)

Copy link
Contributor Author

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 13 of 15 files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)


src/ServiceToolkit/src/SIL.ServiceToolkit/Services/BugsnagMiddleware.cs line 6 at r1 (raw file):

Previously, johnml1135 (John Lambert) wrote…

Is this just a copy-paste from the Bugsnag implementation? If it is, can you reference the source of it in a comment? In 3 years, Bugsnag may update some of it and it would be nice to know what is the same and different, and when it was forked.

Done.

- update OpenTelemetry
- update MassTransit
- remove Bugsnag.AspNet.Core, implement natively
- fixes #544
Copy link
Collaborator

@johnml1135 johnml1135 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)

@johnml1135 johnml1135 merged commit 69fa745 into main Dec 3, 2024
3 checks passed
@johnml1135 johnml1135 deleted the vulnerabilities branch December 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugsnag.AspNet.Core has dependencies on deprecated/vulnerable packages
4 participants