-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies with vulnerabilities #549
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #549 +/- ##
==========================================
+ Coverage 57.03% 57.08% +0.04%
==========================================
Files 302 304 +2
Lines 15639 15720 +81
Branches 2155 2163 +8
==========================================
+ Hits 8919 8973 +54
- Misses 6076 6099 +23
- Partials 644 648 +4 ☔ View full report in Codecov by Sentry. |
Is this just a copy-paste from the Bugsnag implementation? If it is, can you reference the source of it in a comment? In 3 years, Bugsnag may update some of it and it would be nice to know what is the same and different, and when it was forked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 15 files at r1, all commit messages.
Reviewable status: 13 of 15 files reviewed, 1 unresolved discussion (waiting on @ddaspit and @johnml1135)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ddaspit)
05489aa
to
5980c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 13 of 15 files reviewed, 1 unresolved discussion (waiting on @Enkidu93 and @johnml1135)
src/ServiceToolkit/src/SIL.ServiceToolkit/Services/BugsnagMiddleware.cs
line 6 at r1 (raw file):
Previously, johnml1135 (John Lambert) wrote…
Is this just a copy-paste from the Bugsnag implementation? If it is, can you reference the source of it in a comment? In 3 years, Bugsnag may update some of it and it would be nice to know what is the same and different, and when it was forked.
Done.
5980c8e
to
7943979
Compare
- update OpenTelemetry - update MassTransit - remove Bugsnag.AspNet.Core, implement natively - fixes #544
7943979
to
b4b5411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ddaspit)
This change is