Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serval Architecture #572

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Add Serval Architecture #572

merged 1 commit into from
Dec 16, 2024

Conversation

johnml1135
Copy link
Collaborator

@johnml1135 johnml1135 commented Dec 12, 2024

Addresses #540 (in part).


This change is Reviewable

@johnml1135 johnml1135 requested a review from ddaspit December 12, 2024 15:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.97%. Comparing base (5dd100d) to head (3c31faf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   62.97%   62.97%           
=======================================
  Files         279      279           
  Lines       13984    13984           
  Branches     1814     1814           
=======================================
  Hits         8807     8807           
  Misses       4551     4551           
  Partials      626      626           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ddaspit ddaspit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnml1135)

@johnml1135 johnml1135 merged commit cdb2831 into main Dec 16, 2024
3 checks passed
@johnml1135 johnml1135 deleted the add_serval_arch_documentation branch December 16, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants