-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show logo and project abbreviation on mobile #2915
base: master
Are you sure you want to change the base?
Conversation
@Nateowami @nigel-wells we didn't discuss this change, so I'd like to get your thoughts. We don't have to wait til the next UX meeting. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2915 +/- ##
=======================================
Coverage 80.91% 80.92%
=======================================
Files 533 533
Lines 31224 31227 +3
Branches 5085 5063 -22
=======================================
+ Hits 25265 25269 +4
- Misses 5198 5210 +12
+ Partials 761 748 -13 ☔ View full report in Codecov by Sentry. |
Fair enough. I can certainly undo the animation and make it static. My reasons for hiding it are:
As for the help:
As for the language:
As for also showing the project name:
|
The animation was great - I liked that :) How about if we showed just the shortcode? I think there is some value having the current project somewhere easy to discover. The short code won't take up too much space vs the project name. Putting the language into the user menu makes sense to me - it is a set and forget thing. Also, putting it in the user menu means we can give it similar treatment like the razor page where the language word is in full alongside the supporting icon. Feel free to come up with some other versions as well - or just go ahead with what you're thinking. |
Yeah, let's flesh out some ideas in Balsamiq. I wanna make sure I understand you fully and get all the different scenarios processed. |
I went ahead and split out the localization move to #2922. I'd like to keep things separated, so that we don't get everything hung up if one item turns out to be controversial. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great - will be even better when the language is moved too.
This allows navigation to My Projects when clicking the menu drawer on phones. It's a little confusing that the logo is present on desktop but not mobile. Users with both will be wondering where to go. This solution maintains the original intent of minimizing onscreen clutter for mobile. (We don't have enough space to show the project name, but this is okay.)
- Made logo visible all the time - Project short name is shown on mobile - Project name area is clickable
827b99b
to
ed5a5ea
Compare
This allows navigation to My Projects when clicking the menu drawer on phones. It's a little confusing that the logo is present on desktop but not mobile. Users with both will be wondering where to go. This solution maintains the original intent of minimizing onscreen clutter for mobile.
(We don't have enough space to show the project name, but this is okay.)
This change is