SF-3120 Replace toPromise with lastValueFrom

[josephmyers]

This change is 

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (0ac32be) to head (f9d5bdd).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2918      +/-   ##
==========================================
- Coverage   80.90%   80.90%   -0.01%     
==========================================
  Files         533      533              
  Lines       31201    31200       -1     
  Branches     5082     5077       -5     
==========================================
- Hits        25244    25243       -1     
  Misses       5196     5196              
  Partials      761      761              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pmachapman]

Just a couple of nits!

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @josephmyers)

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/retrying-request.service.ts line 99 at r1 (raw file):

  private async invoke(options: FetchOptions): Promise<T | undefined> {
    while (!this.canceled && this.status !== 'complete') {
      const online = await lastValueFrom(this.online$.pipe(take(1)));

NIT: This could be simplified as:

const online = await firstValueFrom(this.online$);

Code quote:

const online = await lastValueFrom(this.online$.pipe(take(1)));

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/retrying-request.service.ts line 132 at r1 (raw file):

        take(1)
      )
    );

NIT: This could also be simplified as:

await firstValueFrom(this.online$.pipe(filter(isOnline => isOnline)));

Code quote:

    await lastValueFrom(
      this.online$.pipe(
        filter(isOnline => isOnline),
        take(1)
      )
    );

[josephmyers]

These two make sense, thanks

Reviewable status: 9 of 11 files reviewed, all discussions resolved (waiting on @pmachapman)

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/retrying-request.service.ts line 99 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

NIT: This could be simplified as:

const online = await firstValueFrom(this.online$);

Done, thanks

---

src/SIL.XForge.Scripture/ClientApp/src/xforge-common/retrying-request.service.ts line 132 at r1 (raw file):

Previously, pmachapman (Peter Chapman) wrote…

NIT: This could also be simplified as:

await firstValueFrom(this.online$.pipe(filter(isOnline => isOnline)));

Done

[pmachapman]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @josephmyers)