Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: clean up and update ansible, upgrade to mongo 8 #2921

Merged
merged 9 commits into from
Dec 22, 2024

Conversation

marksvc
Copy link
Collaborator

@marksvc marksvc commented Dec 18, 2024

  • dev: clean up workstation ansible files
  • dev: improve dev server ansible playbook file naming
  • dev: delint ansible
  • dev: remove more ansible lint
  • dev: incorporate dep ansible into dev-server playbook
  • dev: omit dotnet pkg repo key and source
  • dev: update mongodb ansible
  • dev: ansible: upgrade mongo from 7 to 8

This change is Reviewable

@marksvc marksvc changed the title task/sf ansible dev: clean up and update ansible, upgrade to mongo 8 Dec 18, 2024
@marksvc
Copy link
Collaborator Author

marksvc commented Dec 18, 2024

dotnet packages for Ubuntu 22.04+ are now maintained in the official, Ubuntu repositories.

This PR can be squashed into a single commit with only the subject and no body.

@pmachapman pmachapman self-requested a review December 18, 2024 22:01
@pmachapman pmachapman self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (f54210b) to head (b631edd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2921   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files         533      533           
  Lines       31224    31224           
  Branches     5085     5063   -22     
=======================================
  Hits        25265    25265           
- Misses       5198     5210   +12     
+ Partials      761      749   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question!

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @marksvc)


.gitmodules line 8 at r1 (raw file):

	path = deploy/roles/apache_config
	url = https://github.com/saygoweb/ansible-role-apache.git
	branch = master-our

Is it possible to just delete .gitmodules, instead of clearing it?

Code quote:

[submodule "deploy/roles_common"]
	path = deploy/roles_common
	url = https://github.com/sillsdev/ops-ansible-common-roles
	branch = master
[submodule "deploy/roles/apache_config"]
	path = deploy/roles/apache_config
	url = https://github.com/saygoweb/ansible-role-apache.git
	branch = master-our

@marksvc
Copy link
Collaborator Author

marksvc commented Dec 20, 2024

I was wondering if that would happen automatically, but I guess not.

Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @marksvc)

@pmachapman pmachapman merged commit 1bca82f into master Dec 22, 2024
17 checks passed
@pmachapman pmachapman deleted the task/sf-ansible branch December 22, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants