Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove learning rate adjustment and notice #2933

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Jan 5, 2025

As the 60 days have passed and Serval automatically sets this rate for us, this PR reverts the following PRs:

The feature flag is retained so an version numbers with the feature flag will be parsed correctly.


This change is Reviewable

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (53fa502) to head (e9224d5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2933      +/-   ##
==========================================
- Coverage   80.91%   80.90%   -0.01%     
==========================================
  Files         533      533              
  Lines       31225    31204      -21     
  Branches     5085     5082       -3     
==========================================
- Hits        25267    25247      -20     
  Misses       5198     5198              
+ Partials      760      759       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@josephmyers josephmyers self-assigned this Jan 6, 2025
Copy link
Collaborator

@josephmyers josephmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@josephmyers josephmyers merged commit ec1d939 into master Jan 6, 2025
17 checks passed
@josephmyers josephmyers deleted the fix/remove-learning-rate-adjustment branch January 6, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants