Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: accept relative path or enforce absolute path #88

Closed
juhp opened this issue Oct 13, 2021 · 3 comments
Closed

setup: accept relative path or enforce absolute path #88

juhp opened this issue Oct 13, 2021 · 3 comments

Comments

@juhp
Copy link

juhp commented Oct 13, 2021

I had a quick play with eureka and thought I would report my initial impressions:

During setup a relative path is accepted (probably anything even).
Then when running eureka it panics with Could not locate repo at: sdfsdf.

If possible it might be better just to init a git repo in a default location.
Perhaps there is some cross-platform library that could help with that?
Not sure if making the branch configurable is really needed at setup time (modern git defaults to main)?
You could also have a --clone option to get a remote repo.

You could use ~/.eureka for configuring an alternative repo location location.

@simeg
Copy link
Owner

simeg commented Dec 29, 2021

Hi @juhp!

Enforcing absolute path sounds easier than trying to figure out a relative path. The path is persisted to disk so it needs to be absolute. I agree that makes sense.

If possible it might be better just to init a git repo in a default location.

I like that idea -- it can be an optional step during the setup. That would save the user some manual work.

Not sure if making the branch configurable is really needed at setup time (modern git defaults to main)?

I'm trying to remember why I decided this was a good idea because I can't think of a good reason to have it right now. The program assumes you have a separate repo for your ideas so why should it not assume you're using the default branch? I will default to main in an upcoming version.

You could also have a --clone option to get a remote repo.

Can you expand on this idea?

Apologies for the late response.

simeg added a commit that referenced this issue Dec 29, 2021
* Github defaults to main as branch name nowadays so it makes sense to
  eureka to do the same.
* As pointed out in #88 why is the branch name even configurable? I
  can't think of a good reason so let's just remove it.
@simeg simeg mentioned this issue Dec 29, 2021
simeg added a commit that referenced this issue Dec 29, 2021
* Github defaults to main as branch name nowadays so it makes sense to
  eureka to do the same.
* As pointed out in #88 why is the branch name even configurable? I
  can't think of a good reason so let's just remove it.
simeg added a commit that referenced this issue Apr 10, 2022
* Github defaults to main as branch name nowadays so it makes sense to
  eureka to do the same.
* As pointed out in #88 why is the branch name even configurable? I
  can't think of a good reason so let's just remove it.
@simeg
Copy link
Owner

simeg commented Apr 11, 2022

Thanks again for the good ideas @juhp! I've implemented some of them and created separate issues for the rest.

@simeg simeg closed this as completed Apr 11, 2022
@juhp
Copy link
Author

juhp commented Apr 18, 2022

Thanks - I may have another play with it later :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants