-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup: accept relative path or enforce absolute path #88
Comments
Hi @juhp! Enforcing absolute path sounds easier than trying to figure out a relative path. The path is persisted to disk so it needs to be absolute. I agree that makes sense.
I like that idea -- it can be an optional step during the setup. That would save the user some manual work.
I'm trying to remember why I decided this was a good idea because I can't think of a good reason to have it right now. The program assumes you have a separate repo for your ideas so why should it not assume you're using the default branch? I will default to
Can you expand on this idea? Apologies for the late response. |
* Github defaults to main as branch name nowadays so it makes sense to eureka to do the same. * As pointed out in #88 why is the branch name even configurable? I can't think of a good reason so let's just remove it.
* Github defaults to main as branch name nowadays so it makes sense to eureka to do the same. * As pointed out in #88 why is the branch name even configurable? I can't think of a good reason so let's just remove it.
* Github defaults to main as branch name nowadays so it makes sense to eureka to do the same. * As pointed out in #88 why is the branch name even configurable? I can't think of a good reason so let's just remove it.
Thanks again for the good ideas @juhp! I've implemented some of them and created separate issues for the rest.
|
Thanks - I may have another play with it later :) |
I had a quick play with eureka and thought I would report my initial impressions:
During setup a relative path is accepted (probably anything even).
Then when running eureka it panics with
Could not locate repo at: sdfsdf
.If possible it might be better just to init a git repo in a default location.
Perhaps there is some cross-platform library that could help with that?
Not sure if making the branch configurable is really needed at setup time (modern git defaults to
main
)?You could also have a
--clone
option to get a remote repo.You could use ~/.eureka for configuring an alternative repo location location.
The text was updated successfully, but these errors were encountered: