Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify default branch to main #89

Closed
wants to merge 1 commit into from
Closed

modify default branch to main #89

wants to merge 1 commit into from

Conversation

AlFalahTaieb
Copy link

Changing the base branch name from master to main.

GitHub default branch is now main instead of master, by changing it to main, this will avoid creating a new branch when we write a new idea, it will directly push to the main branch instead of creating a master branch.

@simeg
Copy link
Owner

simeg commented Dec 29, 2021

@AlFalahTaieb Thanks! This change definitely makes sense. However this will break the program for current users. Have you given any thought on how to deal with that?

A major version bump is justified but perhaps there's more we can do to help users "migrate".

@simeg
Copy link
Owner

simeg commented Dec 29, 2021

After reading #88 I can't think of a good reason to have the branch configurable. I will remove it and default to main.

The breaking problem is still there so curious to hear your thoughts @AlFalahTaieb

@simeg
Copy link
Owner

simeg commented Apr 10, 2022

This will be fixed in #90.

@simeg simeg closed this Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants