-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements a Complementary Filter for intelligently fusing yaw from multiple sources #3
Open
nanospork
wants to merge
22
commits into
simlrh:master
Choose a base branch
from
nanospork:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eed to fix the -180<->+180 problem.
…s component now works properly using angularVelocity and angle wrapping works as well.
…ow. Tweaked yaw reset trigger settings.
…set. Now takes a path instead of a boolean.
…logic and used more descriptive function name.
Looks good. Can't review code until late September (sorry) so talk then. |
Fix cmake for linux compilation.
Do you want maintainer on OSVR-fusion? I’m working full time and can’t make it to my workshop often |
… working in FilteredOrientationReader. Still needs cleanup.
Sure! I’m in the same situation, but I suppose two of us getting to it infrequently is better than one? ;) |
Ok, you have push access, go nuts! |
Got manual 'soft' yaw reset (ignores translational coordinate system)…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a complementary filter (a straightforward introduction here: http://www.pieter-jan.com/node/11) that allows for intelligent fusion of yaw data from a "fast" source with data from an "accurate" source.
The complementary filter is more or less equivalent to one of the most basic implementations of the Kalman filter (http://www.olliw.eu/2013/imu-data-fusing/). The complementary filter high-passes data from the "fast" source while low-passing data from the "accurate" source, creating a signal that is responsive in the short term while remaining accurate in the long term.
The complementary filter is tuned with a simple "alpha" parameter. I've added an example to the readme that shows what terms to add to the
orientation
object within the server config file.A
recenterButton
object can also be added to theorientation
object. This object points to a semantic path such as a controller button. TheFilteredOrientationReader
then listens for a button press on this path and if one is detected and there is significant error between the last filter input and the current input, the filter will instantly backfill to the new input. In short, this is an attempt to detect external yaw recentering in the "accurate" yaw source and provide the user with a "snappy" recentering experience, rather than allowing the filter to slowly recenter the device (and cause nausea if used with an HMD).I've been working on this as part of a larger project I'm (tentatively) calling NOFC - the Nolo OSVR Fusion Configuration, which takes advantage of the Nolo-OSVR plugin, the OSVR-Fusion plugin, and an update to the SteamVR-OSVR plugin for much better performance using Nolo hardware with OSVR.
I think you'll find that this new filter is right at home in OSVR-Fusion, and that it will allow users to improve their yaw performance not just with Nolo and the HDK, but with a number of other hardware configurations as well.
Let me know if you have any questions about how the filter works, or if there are any changes you would like to see or discussion you would like to have before merging!