feat(react): expose viewportRef prop in SelectionArea #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also noticed wrong typing in react props, so fixed it |
|
Awesome, thank you! I'll take a closer look at the end of the week :) |
|
Hey, I'm a bit confused, the issue described in #193 is something in the vanilla / core package. How does this PR fix this issue? |
|
Ouu so my fault. Somehow I assumed that it is about react. Anyway, I had exact same issue in React. Fix here is working for me and I am satisfied that I can attach scrollable div to this lib and use it as earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #193
Feel free to modify this PR.
Feature is backward compatible
I tested it in my project and look that it worked exactly I described in my stackblitz