feature(toSlpRegtestAddress): #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 4, 2020 13:43
exposing toSlpRegtestAddress from bchaddrjs-slp
test slp mainnet to regtest
…RegtestAddress function
jcramer
reviewed
Feb 28, 2021
| @@ -1,4 +1,4 @@ | |||
| import * as Bchaddr from "bchaddrjs-slp"; | |||
| import * as Bchaddr from "bchaddrjs-slp-2"; | |||
There was a problem hiding this comment.
Why is this library being used? Afaict there isn't any difference other than the -2 version is behind by 1 commit.
There was a problem hiding this comment.
Because the current bchaddrjs-slp don't have toSlpRegtestAddress.
npm run build ⮂
> [email protected] build /Users/naach/dev/af/slpjs
> tsc && mkdirp dist && browserify index.js --standalone slpjs > dist/slpjs.js && uglifyjs dist/slpjs.js > dist/slpjs.min.js
lib/utils.ts:42:24 - error TS2339: Property 'toSlpRegtestAddress' does not exist on type 'typeof import("bchaddrjs-slp")'.
42 return Bchaddr.toSlpRegtestAddress(address);
~~~~~~~~~~~~~~~~~~~
Found 1 error.
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] build: `tsc && mkdirp dist && browserify index.js --standalone slpjs > dist/slpjs.js && uglifyjs dist/slpjs.js > dist/slpjs.min.js`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the [email protected] build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR! /Users/naach/.npm/_logs/2021-03-01T09_39_56_001Z-debug.log
(base) ~/dev/af/slpjs ⮀ feature/toSlpRegtestAddress● ⮀ 116d2h59m ⮀ node -v ⮂
v12.21.0
but I was able to get toSlpRegtestAddress working here for some reason
https://repl.it/@SuperCipher/bchaddr-test#index.js
jcramer
reviewed
Feb 28, 2021
| @@ -6,15 +6,16 @@ | |||
| "downlevelIteration": true, | |||
| "moduleResolution": "node", | |||
| "esModuleInterop": true, | |||
| "lib":[ "es2017" ], | |||
| "lib":[ "es2017","dom" ], | |||
There was a problem hiding this comment.
why is "dom" being included?
There was a problem hiding this comment.
this is a fix for an error tsc can't find element
https://stackoverflow.com/questions/57999416/typescript-puppeteer-library-error-cannot-find-name-element
npm run build ⮂
> [email protected] build /Users/naach/dev/af/slpjs
> npx tsc && mkdirp dist && browserify index.js --standalone slpjs > dist/slpjs.js && uglifyjs dist/slpjs.js > dist/slpjs.min.js
../../node_modules/@types/sizzle/index.d.ts:14:35 - error TS2304: Cannot find name 'Element'.
14 <TArrayLike extends ArrayLike<Element>>(selector: string, context: Element | Document | DocumentFragment, results: TArrayLike): TArrayLike;
~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:14:72 - error TS2304: Cannot find name 'Element'.
14 <TArrayLike extends ArrayLike<Element>>(selector: string, context: Element | Document | DocumentFragment, results: TArrayLike): TArrayLike;
~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:14:82 - error TS2304: Cannot find name 'Document'.
14 <TArrayLike extends ArrayLike<Element>>(selector: string, context: Element | Document | DocumentFragment, results: TArrayLike): TArrayLike;
~~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:14:93 - error TS2304: Cannot find name 'DocumentFragment'.
14 <TArrayLike extends ArrayLike<Element>>(selector: string, context: Element | Document | DocumentFragment, results: TArrayLike): TArrayLike;
~~~~~~~~~~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:15:34 - error TS2304: Cannot find name 'Element'.
15 (selector: string, context?: Element | Document | DocumentFragment): Element[];
~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:15:44 - error TS2304: Cannot find name 'Document'.
15 (selector: string, context?: Element | Document | DocumentFragment): Element[];
~~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:15:55 - error TS2304: Cannot find name 'DocumentFragment'.
15 (selector: string, context?: Element | Document | DocumentFragment): Element[];
~~~~~~~~~~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:15:74 - error TS2304: Cannot find name 'Element'.
15 (selector: string, context?: Element | Document | DocumentFragment): Element[];
~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:18:28 - error TS2304: Cannot find name 'Element'.
18 matchSelector(element: Element, selector: string): boolean;
~~~~~~~
../../node_modules/@types/sizzle/index.d.ts:19:41 - error TS2304: Cannot find name 'Element'.
jcramer
reviewed
Feb 28, 2021
| "declaration": true, | ||
| "sourceMap": true, | ||
| "plugins": [ | ||
| { "name": "typescript-tslint-plugin" } | ||
| ] | ||
| }, | ||
| "include": [ | ||
| "lib/**/*.ts" | ||
| "lib/**/*.ts", | ||
| "./typings-custom/**/*.ts" |
There was a problem hiding this comment.
I'm not able to find any "typings-custom" files. Why is this needed?
There was a problem hiding this comment.
Sorry, I forgot to remove that, it's actually not necessary.
|
Closing this, as we've discussed elsewhere. See simpleledger/SLPDB#82. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exposing toSlpRegtestAddress from bchaddrjs-slp