Remove slow and unncessary resetClones function

simplyboo6 · Apr 30, 2024 · 95a8663 · 95a8663
1 parent ad22997
commit 95a8663
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 17 deletions.
diff --git a/server/src/cache/clone-map.ts b/server/src/cache/clone-map.ts
@@ -42,9 +42,6 @@ export function generateImageCloneMap(
 ): ExecutorPromise<any> {
   return execute(
     async () => {
-      // First reset the clone map.
-      await database.resetClones();
-
       // Now find all phashed
       const imagesRaw = await database.subsetFields(
         { type: { equalsAll: ['still'] }, phashed: true, duplicateOf: { exists: false } },
@@ -55,7 +52,7 @@ export function generateImageCloneMap(
         return {
           hash: image.hash,
           phash: image.phash!,
-          clones: image.clones,
+          clones: [],
         };
       });
 
@@ -109,6 +106,8 @@ export function generateImageCloneMap(
             if (data.err) {
               reject(data.err);
             } else if (data.clones) {
+              // data.clones is always set unless there is an error.
+              // That means this is a clear operation too.
               database
                 .saveMedia(data.hash, {
                   clones: data.clones.map((c) => c.hash),

diff --git a/server/src/database/mongodb/index.ts b/server/src/database/mongodb/index.ts
@@ -527,11 +527,6 @@ export class MongoConnector extends Database {
     return undefined;
   }
 
-  public async resetClones(): Promise<void> {
-    const collection = this.db.collection<BaseMedia>('media');
-    await collection.updateMany({}, { $unset: { clones: '' } });
-  }
-
   public async resetAutoTags(): Promise<void> {
     const collection = this.db.collection<BaseMedia>('media');
     const result = await collection.updateMany({ autoTags: { $exists: true } }, { $unset: { autoTags: '' } });

diff --git a/server/src/database/sqlite/index.ts b/server/src/database/sqlite/index.ts
@@ -390,13 +390,6 @@ export class SqliteConnector extends Database {
     return Promise.resolve();
   }
 
-  public resetClones(): Promise<void> {
-    this.db.exec(
-      'UPDATE `media` SET `clones` = NULL WHERE `hash` IN (SELECT `hash` FROM `media` WHERE `clones` IS NOT NULL)',
-    );
-    return Promise.resolve();
-  }
-
   public async resetAutoTags(): Promise<void> {
     this.db.exec(
       'UPDATE `media` SET `auto_tags` = NULL WHERE `hash` IN (SELECT `hash` FROM `media` WHERE `auto_tags` IS NOT NULL)',

diff --git a/server/src/types/database.ts b/server/src/types/database.ts
@@ -66,7 +66,6 @@ export abstract class Database {
 
   // Utility
   public abstract close(): Promise<void>;
-  public abstract resetClones(): Promise<void>;
   public abstract resetAutoTags(): Promise<void>;
 
   // Clears data from all tables. Implementation should check TEST_MODE=1 is set.