Fix scan find #442
Fix scan find #442
Conversation
| @@ -22,7 +22,7 @@ read | |||
|
|
|||
| # Note: openssl no longer required | |||
| # Apple's provided flex is 2.6.4, which is the same that is provided by brew | |||
| PKGS+="wget libtool autoconf automake libtool libxml2 libewf json-c" | |||
| PKGS+="wget libtool autoconf automake libtool libxml2 libewf json-c re2 abseil pkg-config" | |||
There was a problem hiding this comment.
If you're requiring pkg-config, you can add ax_pkg_check_modules.m4 to your m4 directory and then use PKG_CHECK_MODULES() in configure.ac to check on the existence/presence of pkg-config-managed packages and gather up their different CFLAGS and LIBS directives into namespaced variables, so you can incorporate those into Makefile.am.
There was a problem hiding this comment.
Yes. I'm in fact using this now. See
https://github.com/simsong/be20_api/blob/0bd6a2a8a72dffcc867cef478a3f84cf306f131f/be20_configure.m4#L31-L40
And you know what? I just spent 8 hours trying to debug this.
| feature_recorder &f = sp.named_feature_recorder("find"); | ||
|
|
||
| auto *tbuf = sbuf_t::sbuf_malloc(sp.sbuf->pos0, sp.sbuf->bufsize+1, sp.sbuf->bufsize+1); | ||
| memcpy(tbuf->malloc_buf(), sp.sbuf->get_buf(), sp.sbuf->bufsize); |
There was a problem hiding this comment.
are you doing the memcpy solely so you can null-terminate it?
| @@ -79,33 +117,16 @@ void scan_find(scanner_params &sp) | |||
| /* The current regex library treats \0 as the end of a string. | |||
| * So we make a copy of the current buffer to search that's one bigger, and the copy has a \0 at the end. | |||
| * This is super-wasteful. Does Lightgrep have this problem? | |||
There was a problem hiding this comment.
to answer definitively: no
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
+ Coverage 47.96% 48.48% +0.52%
==========================================
Files 112 112
Lines 13390 13167 -223
==========================================
- Hits 6422 6383 -39
+ Misses 6968 6784 -184 ☔ View full report in Codecov by Sentry. |
No description provided.