add check for user defined hostname #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
|
The test need some kind of mocking, yes. |
|
Thanks. Will add test cases too. |
|
I am not that much comfortable with AVA for testing. It might take some time (or forever) for me to get this done. You could merge this if that's ok. I can add test cases later on as and when i get some spare time. Updating readme for the added functionality. |
I'm not interested in merging untested code.
From experience, that never happens. |
|
Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#61
Is it how we are expecting it to be? Can add to documentation if this seems good.
Also any suggestions as to how to write test cases for this. Current tests already fails. Shall we use something like msw to mock requests for testing the custom host functionality?