Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve user experience of the meeting media page #3249

Merged
merged 7 commits into from
Nov 11, 2024
Merged

feat: improve user experience of the meeting media page #3249

merged 7 commits into from
Nov 11, 2024

Conversation

mtdvlpr
Copy link
Collaborator

@mtdvlpr mtdvlpr commented Nov 11, 2024 •
edited
Loading

Proposed Changes

This PR improves the overall user experience of the meeting media page.

If applicable, list the changes in a list:

  • feat: ability to add additional media to specific section
  • feat: add "add extra media" actions to CO and LaC section
  • feat: add "add a concluding song" shortcut action to CO section
  • fix: always show tgw/ayfm/lac sections for midweek meeting and wt section for weekend meeting
  • fix: show empty section message when section only contains hidden media
  • refactor: move opening song reminder to public talk section
  • refactor: move co week media reminder to CO section

Related to #2980

@github-actions github-actions bot added the enhancement New feature or request label Nov 11, 2024
@mtdvlpr mtdvlpr requested a review from sircharlo November 11, 2024 11:37
@mtdvlpr mtdvlpr mentioned this pull request Nov 11, 2024
Closed
@mtdvlpr mtdvlpr changed the title feat: ability to add media to specific section feat: improve media calendar user experience Nov 11, 2024
@mtdvlpr mtdvlpr changed the title feat: improve media calendar user experience feat: improve media calendar page user experience Nov 11, 2024
@mtdvlpr mtdvlpr changed the title feat: improve media calendar page user experience feat: improve user experience of the meeting media page Nov 11, 2024
@sircharlo
Copy link
Owner

Great stuff!

@sircharlo sircharlo merged commit 7c2985b into master Nov 11, 2024
7 of 8 checks passed
@sircharlo sircharlo deleted the feat/add-to-section branch November 11, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sircharlo sircharlo sircharlo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtdvlpr @sircharlo