-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve extra media indicators #3452
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Looks nice. @sircharlo what do you think? Does it even make sense to mark the imported song with a different icon? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@ux-git, same issue with the monitored indicator. If a song is extracted from a watched jwl playlist file, which badge do we show? I feel like we're over-engineering this a bit. Should we just either show the extra media / monitored icon OR the song icon when both apply? |
…ra-media-indicator
Yeah, looks great. I personally feel it's very useful to the end user to indicate what is manually / watcher imported vs. automatic. |
What about having a left and right area in the folder icon? Left could show if folder is watched or not, right could show song. Just a thought. That way, we'd have a few possibilities:
|
Okay, so we have the following options:
|
For a monitored folder, what about something like this, but with an eye or a lightning bolt instead of a cog:
|
For the watched folder, I think an eye icon would fit best. |
Do we even need to show the watched folder media? What is a user case where having the custom media indicator won't be enough? |
I agree. I think having a unique icon for each edge case is overkill. |
@mtdvlpr would those two icons cover all the main custom categories/cases? |
You mean use the Add Media icon for non-watched added media? |
Plus, the eye in the watched folder icon has been significantly enlarged now, already in Figma |
Yes |
How should I get the correct svg code for the icons? I've been right clicking them and then copy as svg. Is there a better way? |
Depending on the workflow: either click on the parent container, and then copy as SVG, or select multiple and click + on the right side Export panel, or use a plugins, I'm pretty sure there's one that shows the code. |
Looks better to me. Your thoughts guys? |
Click on icon in UI Kit > Export > SVG |
Sounds good! |
I think so. Playback indicator near the playback controls. Would it make sense to make it clickable to turn it off? Or is it tricky considering that it must be turned only through the More menu? |
Again, I'm torn 😃 Option 1: Clickable Toggle
Option 2: Context Menu Option
|
(I'm leaning towards option 2 personally.) |
Me too. If user 1. found this option, 2. and he needs it – then they're advanced enough users. |
LGTM! |
Proposed Changes
A clear and concise description of the changes in this pull request.
If applicable, list the changes in a list:
Related to #[issue/discussion nr. here]