Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of sorting/grouping logic #3864

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Conversation

sircharlo
Copy link
Owner

@sircharlo sircharlo commented Dec 30, 2024

This is a playground to eventually simplify and improve the logic of sorting and grouping, and even allow for collapsible groups (such as for referred publications).

Todo

  • Refactor day media to allow children in DynamicMediaObject, group based on extractCaption
  • Fix lookupPeriod indicate type of item ("dynamic", "watched", "additional")
  • Fix lookupPeriod clear to not wipe lookupPeriod, but rather to remove dynamically added items
  • Get rid of separate mediaSort object
  • Add "initial position" key to be able to reset sort
  • Get rid of separate additionalMediaMaps object; fold into lookupPeriod
  • Get rid of separate watchedMedia object
  • Have all media elements live in one place (lookupPeriod), to allow for intuitive sorting and persisting
  • Create new MediaItemOrGroup component, that will be used to display an item or group
  • Use something like https://github.com/MaxLeiter/sortablejs-vue3 as a replacement for @formkit/drag-and-drop
  • Allow sorting of watched and additional media
  • Persist drag-and-drop sorting
  • Re-enable Reset Sort button
  • Run addDayToExportQueue after sorting
  • Restore drag/drop sorting + drop files into window behaviour

@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Dec 30, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant