Ported to 1.21.2 #58
Open
Ported to 1.21.2 #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sisby-folk
reviewed
Nov 13, 2024
| @@ -65,7 +65,7 @@ jar { | |||
| } | |||
|
|
|||
| loom { | |||
| accessWidenerPath = file("src/main/resources/${modId}.accesswidener") | |||
sisby-folk
reviewed
Nov 13, 2024
| @@ -17,9 +17,9 @@ authors=Sisby folk | |||
| contributors=Ampflower, falkreon, jaskarth, Garden System | |||
| license=LGPL-3.0-or-later | |||
| # Mod Version | |||
| baseVersion=0.6.25 | |||
sisby-folk
reviewed
Nov 13, 2024
| @@ -12,12 +12,7 @@ | |||
| import folk.sisby.surveyor.terrain.RegionSummary; | |||
| import folk.sisby.surveyor.util.ChunkUtil; | |||
| import folk.sisby.surveyor.util.MapUtil; | |||
| import net.minecraft.nbt.NbtCompound; | |||
There was a problem hiding this comment.
ignoring editorconfig here, you need to fix your IDE setup.
sisby-folk
reviewed
Nov 13, 2024
| @@ -127,7 +127,7 @@ public void writeBuf(PacketByteBuf buf) { | |||
| UInts.writeBuf(glint, buf); | |||
| } | |||
|
|
|||
| public void fillEmptyFloors(int depthOffset, int minDepth, int maxDepth, LayerSummary.Raw outLayer) { | |||
sisby-folk
reviewed
Nov 13, 2024
| @@ -5,11 +5,7 @@ | |||
| import net.minecraft.server.network.ServerPlayerEntity; | |||
| import net.minecraft.util.hit.BlockHitResult; | |||
| import net.minecraft.util.hit.HitResult; | |||
| import net.minecraft.util.math.BlockPos; | |||
There was a problem hiding this comment.
editorconfig issue here as well
sisby-folk
reviewed
Nov 13, 2024
| @@ -15,28 +15,28 @@ logoFile = "assets/${modId}/icon.png" | |||
| [properties] | |||
| "connector:placeholder" = true | |||
|
|
|||
| [[dependencies.${ modId }]] | |||
There was a problem hiding this comment.
unclear why this would be the case - is this a change in neo?
There was a problem hiding this comment.
intellij idea throws a warning when the spaces are present. the example neoforge.mods.toml omits them as well
sisby-folk
reviewed
Nov 13, 2024
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "schemaVersion": 1, | |||
| "id": "${modId}", | |||
sisby-folk
reviewed
Nov 13, 2024
| @@ -1,14 +0,0 @@ | |||
| accessWidener v2 named | |||
There was a problem hiding this comment.
I don't think removing this file entirely was intended.
|
doesn't build, many unneccesary changes, IDE isn't respecting .editorconfig. |
sisby-folk
added
the
experimental hotfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
barely got it to work, no changes