style: 💄 typing improvements #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIArgs argparse.Namespace dataclass for improved data modeling in pybind11_stubgen/__init__.py; not necessary to index sys.version_info; custom all_isinstance TypeGuard in fix.py to resolve a type error in arguments to FixedSize vs DynamicSize; use Sequence to accept broader types; typo in FixMissingImport.handle_type?; use comprehension instead of map
ringohoffman
commented
Nov 20, 2023
we don't have typing_extensions as a dependency, so we won't be using this for now
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a draft for #113, and these are some unrelated changes I made in preparation:
CLIArgsargparse.Namespacedataclass for improved type checking inpybind11_stubgen/__init__.pysys.version_info, and doing so interferes with VS Code's reachability highlightingcustomall_isinstanceTypeGuardinpybind11_stubgen/parser/mixins/fix.pyto resolve a type error in arguments toFixedSizevsDynamicSizeSequenceto accept broader typesFixMissingImport.handle_type?map