Fix __hash__ type annotation
#236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Annotating the type of this as `None` like is currently done causes mypy to generate an error, like this: ``` hash.py:2: error: Incompatible types in assignment (expression has type "None", base class "object" defined the type as "Callable[[object], int]") ``` python/mypy#4266 Annotating this as `ClassVar[None]` seems to work. My other attempt of annotating as e.g. `Optional[Callable]` doesn't
auscompgeek
suggested changes
Dec 30, 2024
There was a problem hiding this comment.
This follows the convention used by typeshed to mark a class as unhashable. e.g. array.array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotating the type of this as
Nonelike is currently done causes mypy to generate an error, like this:python/mypy#4266
Annotating this as
ClassVar[None]seems to work. My other attempt of annotating as e.g.Optional[Callable]doesn't