♻️ Abstract SwapVenue Validation to a Method on the Type #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
NotJeremyLiu
force-pushed
the
jl/abstract-instantiation-validation
branch
from
eca2c57
to
22ca57b
Compare
grod220
reviewed
Aug 9, 2023
| @@ -102,6 +103,25 @@ pub struct SwapVenue { | |||
| pub adapter_contract_address: String, | |||
| } | |||
|
|
|||
| impl SwapVenue { | |||
There was a problem hiding this comment.
I think this should be UncheckedSwapVenue
grod220
reviewed
Aug 9, 2023
| &self, | ||
| deps: &DepsMut, | ||
| swap_venue_map: Map<&str, Addr>, | ||
| ) -> Result<Addr, SkipError> { |
grod220
reviewed
Aug 9, 2023
| return Err(ContractError::DuplicateSwapVenueName); | ||
| } | ||
| // Validate the swap venue (checks for valid address and non-duplicate name) | ||
| let checked_swap_contract_address = swap_venue.validate(&deps, SWAP_VENUE_MAP)?; | ||
|
|
||
| // Store the swap venue name and contract address inside the swap venue map | ||
| SWAP_VENUE_MAP.save( |
There was a problem hiding this comment.
Instead of an address, it should store a SwapVenue
NotJeremyLiu
force-pushed
the
jl/abstract-instantiation-validation
branch
from
45aae8c
to
e27cdff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the SwapVenue validation logic out of the entry point contract's instantiate function and into a method implemented on the SwapVenue object itself.