-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor sub modules #78
Conversation
@fkiraly note that I've removed the comment from lgtm-com because we are using CodeQL now (that is name of lgtm functionality that was ported into Github). We need to disable lgtm-com app integration. |
Codecov Report
@@ Coverage Diff @@
## main #78 +/- ##
==========================================
+ Coverage 57.85% 59.12% +1.27%
==========================================
Files 16 22 +6
Lines 1350 1397 +47
==========================================
+ Hits 781 826 +45
- Misses 569 571 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes much sense.
I suppose this is the sktime
equivalent of sorting your garden gnome collection into different cabinets and then arranging them in regular geometric patterns. We can all relate.
Some non-blocking comments:
- should
_remove_single
also be in_nested_seq
? It unnests. _nested_seq
, perhaps better_nested_iter
or_nested_list
(knowing it also applies to tuples)?
I like that analogy! And yep, that's the plan, get everything in an order so it is easier to add the rest of the functionality from here. |
I'll include both updates in a commit, then merge after the tests pass. |
Reference Issues/PRs
Partial implementation of skbase design proposal.
What does this implement/fix? Explain your changes.
Refactors
skbase
functionality intoskbase.base
,skbase.lookup
,skbase.validate
. Presence ofskbase.testing
remains unchanged.