Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] python 3.13 support, add 3.13 to test matrix #471

Merged
merged 9 commits into from
Oct 9, 2024
Merged

[MNT] python 3.13 support, add 3.13 to test matrix #471

merged 9 commits into from
Oct 9, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Sep 29, 2024

Extends the bounds in pyproject.toml to add experimental support for python 3.13, and adds testing on 3.13 to the test matrix.

Full 3.13 support to be added with 2.7.0.

@fkiraly fkiraly added the maintenance Continuous integration, unit testing & package distribution label Sep 29, 2024
@fkiraly fkiraly changed the title [MNT] python 3.13 support, add 3.13 rc2 to test matrix [MNT] python 3.13 support, add 3.13 rc3 to test matrix Oct 3, 2024
@fkiraly fkiraly changed the title [MNT] python 3.13 support, add 3.13 rc3 to test matrix [MNT] python 3.13 support, add 3.13 to test matrix Oct 8, 2024
@fkiraly fkiraly added the release release related PR and issues - checked by release manager label Oct 8, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 8, 2024

numpy seems incompatible with windows, this is the failure:

rm -rf testdir
mkdir -p testdir
cp .coveragerc testdir
cp setup.cfg testdir
python -m pytest
<frozen importlib._bootstrap>:488: Warning: Numpy built with MINGW-W64 on Windows 64 bits is experimental, and only available for 
testing. You are advised not to use it for production. 

CRASHES ARE TO BE EXPECTED - PLEASE REPORT THEM TO NUMPY DEVELOPERS
C:\hostedtoolcache\windows\Python\3.13.0\x64\Lib\site-packages\numpy\core\getlimits.py:225: RuntimeWarning: invalid value encountered in exp2
  epsneg_f128 = exp2(ld(-113))
C:\hostedtoolcache\windows\Python\3.13.0\x64\Lib\site-packages\numpy\core\getlimits.py:226: RuntimeWarning: invalid value encountered in exp2
  tiny_f128 = exp2(ld(-16382))
C:\hostedtoolcache\windows\Python\3.13.0\x64\Lib\site-packages\numpy\core\getlimits.py:240: RuntimeWarning: invalid value encountered in exp2
  eps=exp2(ld(-112)),
C:\hostedtoolcache\windows\Python\3.13.0\x64\Lib\site-packages\numpy\core\getlimits.py:41: RuntimeWarning: invalid value encountered in nextafter
  self._smallest_subnormal = nextafter(
C:\hostedtoolcache\windows\Python\3.13.0\x64\Lib\site-packages\numpy\core\getlimits.py:52: RuntimeWarning: invalid value encountered in log10
  self.precision = int(-log10(self.eps))
make: *** [Makefile:25: test] Error -1073741819

@fkiraly
Copy link
Collaborator Author

fkiraly commented Oct 9, 2024

Hm, must be coming from one of the softdeps, because the no-extras run seems fine. I suspect scikit-survival since in the install phase it is the only dep that builds.

@fkiraly fkiraly merged commit 592b19f into main Oct 9, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution release release related PR and issues - checked by release manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant