Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI workflow to respin a released image #1203

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

fgiorgetti
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #1203 (8d52379) into main (9c75a54) will increase coverage by 0.02%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
+ Coverage   78.29%   78.32%   +0.02%     
==========================================
  Files         243      243              
  Lines       63133    63135       +2     
  Branches     5845     5845              
==========================================
+ Hits        49430    49450      +20     
+ Misses      11063    11043      -20     
- Partials     2640     2642       +2     
Flag Coverage Δ
pysystemtests 87.58% <ø> (+0.01%) ⬆️
pyunittests 54.44% <ø> (ø)
systemtests 72.38% <ø> (+0.04%) ⬆️
unittests 26.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
calculator 30.14% <ø> (ø)
systemtests 78.93% <ø> (+0.02%) ⬆️

@ganeshmurthy
Copy link
Contributor

@fgiorgetti this looks good to me. As part of this PR can you also please change the last steps in this document - https://github.com/skupperproject/skupper-router/blob/main/RELEASE.adoc#re-spinning-an-already-released-skupper-router-version-to-include-cve-changes-from-other-componentbase-images ?

@fgiorgetti
Copy link
Member Author

@fgiorgetti this looks good to me. As part of this PR can you also please change the last steps in this document - https://github.com/skupperproject/skupper-router/blob/main/RELEASE.adoc#re-spinning-an-already-released-skupper-router-version-to-include-cve-changes-from-other-componentbase-images ?

@ganeshmurthy do you mind reviewing the updated instructions?

Copy link
Contributor

@ganeshmurthy ganeshmurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Please go ahead and merge.

@fgiorgetti fgiorgetti merged commit 75641ad into skupperproject:main Sep 18, 2023
22 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants