-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for manifests and config tokens #1220
Conversation
Hi @stijndcl , this looks interesting, can you tell me more about how this will be used, and possibly add a subdirectory with a short README to examples/? |
@parsley42 I can add examples, yes. Will look into it asap. The main goal of this is to integrate the new endpoints from Slack, because I feel an SDK should cover all available endpoints. In terms of use cases, you can use these to dynamically configure your Slack app. The current way is manually creating a If you want more information about how these work or what they are for, the official Slack documentation is at your service: https://api.slack.com/reference/manifests#manifest_apis |
@stijndcl Ah, yes, that would be great! I'm the author of gopherbot, and setting up a robot means editing and uploading a manifest - so it might be a nice feature for new users if this could be automated. However, I do this via the web ui - so, there must be another step for creating credentials that can use this endpoint, which would be helpful to have a README and example for. Thanks! |
@parsley42 there are now two examples. The manifest endpoints are really trivial so it didn't make sense to me to include an example for every single method. One should suffice. I added necessary information about how to handle configuration tokens as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the examples. LGTM.
tooling.tokens.rotate
endpoint, and storeconfigToken
andconfigRefreshToken
in theClient
alongside the other token typesConsidering that Slack allows uploading manifests as both JSON and YAML, but the API docs specify that the manifest submitted to this endpoint should be JSON, I added
yaml:
tags to theManifest
struct to allow users to marshal their existing YAML manifests.