Bot: catch and react to disconnection event #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoberoi
approved these changes
Jul 29, 2019
|
|
|
@mistydemeo works for an organization that has signed the corporate CLA, so the individual CLA check can be safely ignored. |
|
CodeCov has aggregated the coverage report for this PR here: https://codecov.io/gh/slackapi/hubot-slack/pull/572 The GitHub / Travis CI integration does not seem to be working as expected. The coverage is satisfactory, and we're clear to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As described in #536, hubot-slack sometimes appears to disconnect and never come back. There is a
disconnectevent which occurs specifically when the RTM client has disconnected and will not try again; this is currently not handled by the codebase, so that would explain why what we're seeing is going uncaught. In this PR, I've added a new handler for that method; right now I'm having that close the bot entirely, allowing the running process manager to clean up and restart Hubot.Requirements (place an
xin each[ ])