UnusedUses ignores uses in annotations with multi lines string arguments #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tried updating phpdoc-parser? It should be fine, https://github.com/phpstan/phpdoc-parser/releases/tag/1.23.1 fixes this. |
I didn't, I wanted to reproduce the issue first. but looks like it's fixed by updating this dependency, nice timing :) |
|
maybe not worth adding a test then? |
Yes, please. Rebase your branch on master before please. |
mathroc
force-pushed
the
unused-uses-annotation-with-multilines-string-arguments
branch
from
05510f2
to
ffaffaf
Compare
mathroc
force-pushed
the
unused-uses-annotation-with-multilines-string-arguments
branch
from
ffaffaf
to
e7f1729
Compare
done 👍 |
|
Thanks! |
mathroc
deleted the
unused-uses-annotation-with-multilines-string-arguments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduce issue with the Namespaces.UnusedUses sniff that don't detect usages in annotations when the annotation has multiline string arguments
Work in progress: I didn't try running the test locally yet