feat: Add support for struct. output #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gkaretka
commented
Oct 22, 2024
gkaretka
commented
- add support for structured outputs
- with function calling
- with structured outputs
- add support for structured outputs - with function calling - with structured outputs Co-authored-by: Marek Šuppa <[email protected]>
gkaretka
force-pushed
the
gkaretka/add-function-calling
branch
from
df64fde
to
896999e
Compare
samsucik
requested changes
Oct 31, 2024
There was a problem hiding this comment.
@gkaretka thanks a lot for this work. My only concerns are around code quality. This codebase is already quite messy, so let's try to not make it worse -- or else adding further changes will become more and more of a nightmare 😅
gkaretka
force-pushed
the
gkaretka/add-function-calling
branch
from
655b9ef
to
dd05258
Compare
- address PR comments Co-authored-by: Sam Sucik <[email protected]>
gkaretka
force-pushed
the
gkaretka/add-function-calling
branch
from
dd05258
to
2147841
Compare
Co-authored-by: Sam Sucik <[email protected]>
Co-authored-by: Sam Sucik <[email protected]>
Co-authored-by: Sam Sucik <[email protected]>
Co-authored-by: Sam Sucik <[email protected]>
gkaretka
force-pushed
the
gkaretka/add-function-calling
branch
from
dd3ccfb
to
9a102d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.