Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Resolve pnpm lockfile synchronization issue #174

Closed
wants to merge 1 commit into from

Conversation

GIHAA
Copy link
Member

@GIHAA GIHAA commented Apr 12, 2024

No description provided.

@GIHAA
Copy link
Member Author

GIHAA commented Apr 12, 2024

@Akalanka47000 any idea why firebase tests are failng

@Akalanka47000
Copy link
Member

@Akalanka47000 any idea why firebase tests are failng

The firebase tests are using an actual firebase account instead of a mock, the rtdb there had gotten paused, i resumed it should probably work now.

"test": "bash ../../scripts/test/test.sh"
},
"dependencies": {
"@sliit-foss/module-logger": "workspace:*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not go with this approach here, the reason it it becomes difficult to track which packages are updated and which packages aren't if we go with this, since there's a lot of interdependencies between these yes it's easier during development but to the consumer it can become difficult during debugging

@@ -21,7 +21,7 @@
"mongoose": ">=5"
},
"devDependencies": {
"mongoose": "^5"
"mongoose": "^5.13.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this version bump, right now there's no advantage in it right ? Same with the eslint updates above

@GIHAA GIHAA closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants