Add: New package JSON hash added #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lter-support Mongoose filter query - added support for more complex filters
Fix(mongoose-audit): exception when change is null
Add #111 Switch to lefthook for git hooks
Fix #111 Address PR comments
Fix #111 Change lefthook linting command name
Add #111 Switch to lefthook for git hooks
Fix: Docs for default export require statements updated
Add #104 Type support for actions-exec-wrapper added
…rsing Fix(filter-query): added automatic parsing of object ids
Fix(mongoose-filter-query): incorrect parsing of regexp
…ean-parse Fix(mongoose-filter-query): default boolean parsing
…iers Feat(filter-query): added support for regexp modifiers
Feat(service-connector): added support for retrying
…rsing Fix(filter-query): in & nin object id parse
Akalanka47000
requested changes
Jun 23, 2024
packages/json-hash/src/algorthms.js
Outdated
| }; | ||
|
|
||
| export const isAvailableAlgo = (algorithm) => { | ||
| if (Object.prototype.hasOwnProperty.call(algos, algorithm)) { |
There was a problem hiding this comment.
We can use algos[algorithm] here instead right, will be more readable
There was a problem hiding this comment.
Will do
There was a problem hiding this comment.
Done
| const objectToHash = { name: "Siri", age: 30, country: "Sri Lanka" }; | ||
|
|
||
| beforeAll(() => { | ||
| global.unit_tests_running = true; |
There was a problem hiding this comment.
I think we won't need this, this flag was used to handle a few edge cases of tests in a couple of other packages
There was a problem hiding this comment.
Will remove
There was a problem hiding this comment.
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package is intended to be used for hashing a provided JS object in both Node.js and browser(eg-: for Next.js). Users will be provided an option to sort the JS object since order of properties is not guaranteed by JSON.stringify. This sorting will be done using this package which will be imported dynamically. I've kept sorting optional, in case of a string being passed as a parameter to the algorithm.
On the browser side hashing will be done using the inbuilt SubteCrypto Web API which only provides the following algorithms for creating a hash.
In node.js we use the inbuilt crypto module, Even though node.js crpto module provides more algorithms than the ones available in the browser to maintain cross platform compatibility (browser and node.js), I've limited the available algorithms only the ones available in browser.