Throw an error when both DefaultValue and NonNull are present

smallrye · Sep 10, 2024 · 34592be · 34592be
1 parent 01f7b74
commit 34592be
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/common/schema-builder/src/main/java/io/smallrye/graphql/schema/helper/NonNullHelper.java b/common/schema-builder/src/main/java/io/smallrye/graphql/schema/helper/NonNullHelper.java
@@ -1,5 +1,6 @@
 package io.smallrye.graphql.schema.helper;
 
+import io.smallrye.graphql.schema.SchemaBuilderException;
 import org.jboss.jandex.Type;
 import org.jboss.logging.Logger;
 
@@ -55,7 +56,7 @@ public static boolean markAsNonNull(Type type, Annotations annotations, boolean
         boolean hasDefaultValue = hasDefaultValue(annotations);
         if (hasDefaultValue) {
             if (hasNonNull && !type.kind().equals(Type.Kind.PRIMITIVE)) {
-                LOG.warn("Ignoring non null on [" + type.name() + "] as there is a @DefaultValue");
+                throw new SchemaBuilderException("You can't have both @NonNull and @DefaultValue on [" + type.name() + "]");
             }
             return false;
         }