Fixed a problem where during the scanning of InputTypes it included synthetic methods, added a filter + test #1966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ynthetic methods, added a filter + test
jmartisk
approved these changes
Nov 14, 2023
|
@alaa-az hmmm, could you please file a new issue for it (it can be in this repo if you really believe that the problem is in this codebase), preferably with an executable reproducer to demonstrate the issue? |
Sorry for disturbing you. It turned out I am using the wrong annotation |
|
No problem @alaa-az, glad it's working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @jmartisk
fixes: #1963
The problem was caused by not filtering bridge (synthetic) methods in
InputTypeCreator(INPUT). The previous issue only handled theTypeCreator(OUTPUT). That is why if the mutation method is not present in the issue's reproducer, it does not throw the Error. Since the given query has only Output typeGreet.(it is not a MUTATION/QUERY problem but an Input/Output problem).I am not sure why the reproducer with Type Variable
Stringworked and wrapper classes (Long, Integer, etc.) did not—probably some Jandex magic.